External Review and Mission Listings Site

Carnifax · 04-20-2009 08:21 AM

Hmmm. Odd bug on this KS (bugs seem to love me).

When I sort by Author and click on Arctic Princesses Twisted Tales #1 I get JDs Handyman Arc instead.

In fact any of Arctics arcs gives me JDs one instead. I think it's passing the User Id across to view-mission.php rather than the internal Mission Id you use (full URL is : http://www.cityofguides.com/ma/view-mission.php?id=10 for all of APs missions when in a sorted list).

As per usual I'm using Opera. It only appears to happen when viewing a Sorted list of results.

khaine_star · 04-20-2009 08:47 AM

Good spot. Looks like the author id is overwriting the arc id. Will have to get a fix for it.

Judgement_Dave · 04-20-2009 08:47 AM

[ QUOTE ]

When I sort by Author and click on Arctic Princesses Twisted Tales #1 I get JDs Handyman Arc instead.

In fact any of Arctics arcs gives me JDs one instead. I think it's passing the User Id across to view-mission.php rather than the internal Mission Id you use

As per usual I'm using Opera. It only appears to happen when viewing a Sorted list of results.

[/ QUOTE ]
Checked this - Get same issue on order by author.

All other ordering criteria appear fine to me.

And it does appear to be attempting to link using author user_id (supported by the numbers used for the likes of Don Saint who I know registered early...)

Guess you pull back a seperate column/field for use as your unique internal arc id in your query...

Please let it be that and not a seperate display routine dependent upon sort order...

By my mohawk shall ye know me!
my toons
Funny: Ee-Ai-Ee-Ai-Oh! #3662 * The foul-mouthed Handyman! #1076 * City of Norms #132944
Serious: To Save A Single World (#83744) * Marketing Opportunity (#83747)

khaine_star · 04-20-2009 08:52 AM

Simple fixes are always the best. Tis done and dusted. Click away.

Carnifax · 04-20-2009 08:53 AM

[ QUOTE ]
[ QUOTE ]

When I sort by Author and click on Arctic Princesses Twisted Tales #1 I get JDs Handyman Arc instead.

In fact any of Arctics arcs gives me JDs one instead. I think it's passing the User Id across to view-mission.php rather than the internal Mission Id you use

As per usual I'm using Opera. It only appears to happen when viewing a Sorted list of results.

[/ QUOTE ]
Checked this - Get same issue on order by author.

All other ordering criteria appear fine to me.

And it does appear to be attempting to link using author user_id (supported by the numbers used for the likes of Don Saint who I know registered early...)

Guess you pull back a seperate column/field for use as your unique internal arc id in your query...

Please let it be that and not a seperate display routine dependent upon sort order...

[/ QUOTE ]

Pfffft. Stop pretending it wasn't your evil plan in the first place to get everyone playing your arcs JD.

Tis fixed now, that was quick! (and the Evil JD is foiled once more).

*Edit : Uh-oh. I broke it again when logging in :

[ QUOTE ]
Fatal error: Call to a member function getId() on a non-object in /home/fhlinux144/c/cityofguides.com/user/controllers/user/index.php on line 6

[/ QUOTE ]

Go me!

khaine_star · 04-20-2009 08:56 AM

[ QUOTE ]
Guess you pull back a seperate column/field for use as your unique internal arc id in your query...

Please let it be that and not a seperate display routine dependent upon sort order...

[/ QUOTE ]

Actually it was down to a database join connecting the user table to the mission table, both carry an id identifier and since the last one was the user, that's the one that got passed in the final return fieldset.

Judgement_Dave · 04-20-2009 09:00 AM

Can I report an error - Arctic Princess' arcs no longer redirect to my arcs...

By my mohawk shall ye know me!
my toons
Funny: Ee-Ai-Ee-Ai-Oh! #3662 * The foul-mouthed Handyman! #1076 * City of Norms #132944
Serious: To Save A Single World (#83744) * Marketing Opportunity (#83747)

Carnifax · 04-20-2009 09:01 AM

[ QUOTE ]
[ QUOTE ]
Guess you pull back a seperate column/field for use as your unique internal arc id in your query...

Please let it be that and not a seperate display routine dependent upon sort order...

[/ QUOTE ]

Actually it was down to a database join connecting the user table to the mission table, both carry an id identifier and since the last one was the user, that's the one that got passed in the final return fieldset.

[/ QUOTE ]

The amount of fights me and my boss have had over what convention to use in naming Id fields. I'm in the "call them all Id as their real name is TableName.Id" but it can lead to weirdness like this if you forget to alias them as something else when retrieving from a joined query.

Did you see my other error KS?

khaine_star · 04-20-2009 09:03 AM

how do you keep doing that O_O

One thing that is a little annoying is that the errors are supposed to come to us in an email and not plastered across the screen.

khaine_star · 04-20-2009 09:06 AM

Yep seen it, dropped a patch in, although will need to work out how you got there with an invalid user object, which is the only thing that it can be.

All my databases have a primary key of id int(11) unsigned not null auto increment. Makes life easier for writing things like class controllers and database objects.

Carnifax · 04-20-2009 09:07 AM

[ QUOTE ]
how do you keep doing that O_O

One thing that is a little annoying is that the errors are supposed to come to us in an email and not plastered across the screen.

[/ QUOTE ]

Works now, whatever you did to fix it

My ability to generate bugs is pretty handy for developing. It means I see the bugs before some customer does.

Can I be annoying and suggest a change to the Sort by Level Range? No? I'm going to do it anyway . Could you sort by Start and then by the End, so that 1-14s appear together before 1-54s? Useful for looking for lowbie arcs or all arcs in a certain range.

khaine_star · 04-20-2009 09:24 AM

You can suggest all you like.

Although it does sort like that already

/em ninja
/em hide ninja outfit

Carnifax · 04-20-2009 09:27 AM

[ QUOTE ]
You can suggest all you like.

Although it does sort like that already

/em ninja
/em hide ninja outfit

[/ QUOTE ]

Oh yes. My mistake. So it does. Stupid eyes.

Nice new outfit. The black really suits you

khaine_star · 04-20-2009 09:28 AM

Although it seems something has gone wrong with the login process. At present it is 50/50 if it will let you login. I am going to get emo out of bed to have a look at it as I am supposed to be working

khaine_star · 04-20-2009 10:05 AM

damnedest thing. It is working ok now. Turned out to be a host problem not a code one. They seemed to lose session data.

Landlubber · 04-20-2009 01:51 PM

[ QUOTE ]
IMO it would be a good idea to allow reviewers to edit their reviews and for authors to comment against reviews.

Why? I'll tell you why...

* I realised after posting my 1st comment that there was a minor point that I'd wanted to mention but forgot.. wasn't worth a second review but would have been worth adding to the original.

* Part of the feedback process means that arcs may change - an updated review/rating may be better in this case than an additional review leaving the original (now erroneous) review.

* An author may want to question/clarify something raised in a review (e.g. one of my reviews stating it wasn't soloable due to an EB, where my main comeback is that the mob is an EB so can be downgraded to a boss if soloing by playing lowest challenge level).

[/ QUOTE ]

I was just about to post something similar, because that same issue just came up for me. I just added a comment, replying to feedback someone left, but it would be good if the author could edit their original description to add update and change notes.

Oh, and one other thing: will it be possible at some point to view/sort arcs by rating in the overview screen? In that case, I hope 0 gets treated as "no rating" instead of just "abysmally bad", because when I add a comment (as I just did), I obviously wouldn't wan't to rate my own arc, but I wouldn't want to bring down my average either by not doing so

LunaWisp · 04-20-2009 01:58 PM

Would definately be useful to be able to edit a submission to the mission list. I've made some major changes to my 'Lucy' arc and the details on that entry are now out of date.

Judgement_Dave · 04-20-2009 05:40 PM

[ QUOTE ]
Although it seems something has gone wrong with the login process. At present it is 50/50 if it will let you login.

[/ QUOTE ]
I wonder if this problem is back - just tried 5 times to login and it's not logging in just bouncing back to the home page...

By my mohawk shall ye know me!
my toons
Funny: Ee-Ai-Ee-Ai-Oh! #3662 * The foul-mouthed Handyman! #1076 * City of Norms #132944
Serious: To Save A Single World (#83744) * Marketing Opportunity (#83747)

Judgement_Dave · 04-20-2009 05:44 PM

[ QUOTE ]
Would definately be useful to be able to edit a submission to the mission list. I've made some major changes to my 'Lucy' arc and the details on that entry are now out of date.

[/ QUOTE ]
The author can edit the mission description. When you login and it shows you the listings just for your arcs theres an edit button on the far right (you may need to scroll horizontally to see it - it's normally off the side of my window).

It's reviewers/commentators that can't edit their comments.

By my mohawk shall ye know me!
my toons
Funny: Ee-Ai-Ee-Ai-Oh! #3662 * The foul-mouthed Handyman! #1076 * City of Norms #132944
Serious: To Save A Single World (#83744) * Marketing Opportunity (#83747)

Judgement_Dave · 04-20-2009 05:46 PM

Khaine,

Can you increase the size of the comment text entry box please?

And if possible, move to a 2-step comment posting where you can preview/edit comment before posting it, much like these forums.

By my mohawk shall ye know me!
my toons
Funny: Ee-Ai-Ee-Ai-Oh! #3662 * The foul-mouthed Handyman! #1076 * City of Norms #132944
Serious: To Save A Single World (#83744) * Marketing Opportunity (#83747)

khaine_star · 04-20-2009 05:50 PM

[ QUOTE ]
[ QUOTE ]
Although it seems something has gone wrong with the login process. At present it is 50/50 if it will let you login.

[/ QUOTE ]
I wonder if this problem is back - just tried 5 times to login and it's not logging in just bouncing back to the home page...

[/ QUOTE ]

Unfortunately this is a host problem. They have a know fault listed and are apparently working on it. There's nothing I can do about it I will have to work on a cookie system so people can stay logged in regardless of session stuff.

khaine_star · 04-20-2009 06:08 PM

It seems to be back at the moment. So update your stuff quick before it goes again

LunaWisp · 04-20-2009 07:01 PM

[ QUOTE ]
[ QUOTE ]
Would definately be useful to be able to edit a submission to the mission list. I've made some major changes to my 'Lucy' arc and the details on that entry are now out of date.

[/ QUOTE ]
The author can edit the mission description. When you login and it shows you the listings just for your arcs theres an edit button on the far right (you may need to scroll horizontally to see it - it's normally off the side of my window).

It's reviewers/commentators that can't edit their comments.

[/ QUOTE ]

Ah thanks for that, I'll get that sorted when I log back in, seems broken at the moment.

khaine_star · 04-21-2009 05:36 AM

[ QUOTE ]
IMO it would be a good idea to allow reviewers to edit their reviews and for authors to comment against reviews.

[/ QUOTE ]

It would imo too. now we just need to get it written Seriously though it is on the cards to be able to edit your comments. There is also a bit of discussion between me and emo about allowing longer reviews as well as comments. We are also looking at replying to comments/reviews.

[ QUOTE ]
Oh, and one other thing: will it be possible at some point to view/sort arcs by rating in the overview screen? In that case, I hope 0 gets treated as "no rating" instead of just "abysmally bad", because when I add a comment (as I just did), I obviously wouldn't wan't to rate my own arc, but I wouldn't want to bring down my average either by not doing so

[/ QUOTE ]

ooooo-ooo a bug, you aren't supposed to be able to comment on your own arcs. Although the sort idea is not a bad idea. I like to shy away from ratings though as they are very easy to corrupt.

I am going to have to get Emo to restyle a bit as not everyone uses the huge resolutions that we do. I tried the site on another machine and realised just how much goes off screen.

3dent · 04-21-2009 06:08 AM

Please, if you can, also try out the magnification function in the Opera. I use rather high ones, (200+%) and although everything fits now, it does so in rather strange way even on milder mag levels like 140%. (don't ewen ask how I read ingame test. The short answer is: Poorly.) Haven't tried MSIE or FF3 magnificators, but I believe there might be issues too.