Good pvp AT?
Good Scrapper primaries are BS, MA, and Fire. The only good Scrapper secondary is Regen (Elec, Fire, and SR are okay but Regen is just heads above the rest). As far as Defender primaries, you'd want Cold, Rad, or Storm for a solo/damage build - Traps is bad (cue Dahjee saying we're all robots and need to think outside the box). Decent Defender secondaries are Rad, Sonic, and Psi - Dark is okay but the lack of Aim hurts it. Don't even try to build a squishy for defense for PvP, because diminishing returns will reduce that defense to an essentially meaningless number.
"One day we all may see each other elsewhere. In Tyria, in Azeroth. We may pass each other and never know it. And that's sad. But if nothing else, we'll still have Rhode Island."
Or you could wait for Kinetic Melee! With those 18-second animations, it should do killer damage.
But seriously, the optimal Scrapper is going to be Fire/Regin (for max damage), possibly MA/Regin if you like some stuns. Super Reflexes can be quite survivable if done right, but I'd suggest Regen as it's kind of like an i13 PvP starter kit for zones. The reason that Willpower isn't too good is because it doesn't have a heal and instead has a PBAoE Regen Aura that toggles off with every little mez, as well as requiring enemies in melee range (which likely won't happen often). Now, you'll have a lot of HP which is great, and you'll have some resists, but it won't ever compare to Regen. Regen's going to have more "OH ####" tools, as well as having at least 10% resists anyway due to global resist bonuses.
Good Defender primaries, like mac said, are Cold, Rad, and Storm. Although if you're teaming, Empathy is certainly useful. I personally like Cold the most, but that's just me. It's somewhat of a swiss army knife and its debuffs, while slow to recharge, are quite incapacitating. Rad is pretty swiss-army-ish, too. Personal preference will dictate what you choose, but Rad often is considered better.
Or if you're interested in rolling a Blaster, go with Psi, Fire, Sonic, or Rad (in that order, in my opinion) and have either EM or Dev as your secondary. EM is superior to Devices because of Build Up and Boost Range, but Devices has some nice tools like Webnade and Targeting Drone.
I'm assuming that you're only considering heroes as of right now.
/cue Dahjee telling you that you should roll a Sonic/AR Defender.
Man, no love for the DM scrappers :P
"Life is what happens when you are making other plans"
DM is a decent primary if you fiteklub a lot, but the lack of Build Up and the I13 mez changes (remember perma-fear anyone?) really hurt it.
"One day we all may see each other elsewhere. In Tyria, in Azeroth. We may pass each other and never know it. And that's sad. But if nothing else, we'll still have Rhode Island."
Can't deal with the Villain ATs..never liked them and with the defenders getting a damage buff in the current issue i thought It would be fun to roll one for pvp.
Join the Advocates of Fate on Infinity today!

@Inconclusive
I mostly go hero, I'm working on a ice/storm control. (Only to be annoying really) but I was wondering what types are best for pvp and what not. Made a broadsword/WP scrap but apparently Willpower is crap. I was gonna go for Invin and try another set maybe. Also with defenders getting a damage buff I was wondering what would be a good secondary? I was thinking traps as a primary. Was gonna try to soft cap then unload the force field with enhancements.
Join the Advocates of Fate on Infinity today!
@Inconclusive